search

twitter / GraphJet

GraphJet is a real-time graph processing library.
Apache License 2.0
716 stars 111 forks source link

User/Moment recommendations should use NodeMetadata graph #97

Closed guimingTang closed 7 years ago

guimingTang commented 7 years ago

This request changes the interface of User and Moment recommendation pipelines to accept NodeMetadataLeftIndexedMultiSegmentBipartiteGraph. This allows user and moment recommendations to utilize the edge metadata.

rossides commented 7 years ago

I feel like a refactoring where other types of graphs can handle edge metadata is more appropriate. However, this is acceptable for now.

guimingTang commented 7 years ago

Thanks @rossides and @Bwichs for the review and suggestion, I totally agree we could do better by refactoring LeftIndexedMultiSegmentBipartiteGraph to use edge metadata. Will do that in the future :)