twitter / TwitterTextEditor

A standalone, flexible API that provides a full-featured rich text editor for iOS applications.
Apache License 2.0
2.97k stars 161 forks source link

How do I add custom images #17

Open Topwiz opened 3 years ago

Topwiz commented 3 years ago

I was adding image attachments with NSTextAttachment in my custom textView.(Like below) let textAttachment = NSTextAttachment() textAttachment.bounds = CGRect(x: 0, y: (textView.font!.capHeight - image.size.height).rounded() / 2, width: image.size.width, height: image.size.height) textAttachment.image = image let attrStringWithImage = NSAttributedString(attachment: textAttachment) textView.textStorage.replaceCharacters(in: currentRange, with: attrStringWithImage) Is there a way to add images(don't care if is it an NSTextAttachment or a suffixedAttachment) on the textView with TwitterTextEditor?

I found I can get hashtags with regex and place an UIImage or UIView after that hashtag. But I can't find a way how to add just UIImage itself like an NSTextAttachment.

niw commented 3 years ago

Hi, @Topwiz.

This is actually bit difficult on current Twitter Text Editor API design, since it is based on plain text not attributed text.

To use NSTextAttachment to render image within the text view (which is possible in Twitter Text Editor,) but it need to add that attribute to the U+FFFC (NSTextAttachment.character) in the plain text, however Twitter Text Editor API is, intentionally separate plain text updating and attribute updating logic, therefore it is bit difficult to use NSTextAttachment.

I understand however such use case may exist, so will explore new API for that.

MainasuK commented 3 years ago

@Topwiz

I use the TwitterTextEditor layoutManager as the layout backend. And set the image placeholder with space and keep the range. Then replace that space with SuffixedAttachment. It works. Maybe that is what you need.

https://github.com/TwidereProject/ActiveLabel.swift/blob/master/Sources/ActiveLabel/ActiveLabel.swift#L312-L342