search

twitter / TwitterTextEditor

A standalone, flexible API that provides a full-featured rich text editor for iOS applications.
Apache License 2.0
2.97k stars 161 forks source link

Added newline between method declaration and comments #4

Closed kyungkoo closed 3 years ago

kyungkoo commented 3 years ago

added newline between end of method declaration and start of comments to keep the rule.

Problems Most of codes has new line after method declearation. But some codes has no new line between method and comments.

Solution added newline between end of method declaration and start of comments.

Testing run make correct

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

niw commented 3 years ago

These no new lines are actually intentional to group a set of lines. Since these lines has a large inline document comment, it is not obvious but If you see these lines without giant inline document comments, you may see a block of code as like other places in the code base. This is not really coding style or rule, but just regular patterns of maintaining the code blocks.

Thank you for your suggestions, however, since these no new lines are intentional, this will not going to be merged.