Open Peilin-Yang opened 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.23
:tada:
Comparison is base (
f644ba4
) 89.48% compared to head (abf56a8
) 89.72%.:exclamation: Current head abf56a8 differs from pull request most recent head 6b8610d. Consider uploading reports for the commit 6b8610d to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR introduces a simple fix to SketchMap's non-commutative, as illustrated in https://github.com/twitter/algebird/issues/1122
The fix is simply to always put the DenseMatrix as the first param so that the update to it is correct.