twitter / algebird

Abstract Algebra for Scala
https://twitter.github.io/algebird
Apache License 2.0
2.29k stars 346 forks source link

Simple Fix of SketchMap's non-commutative (issue-1122) #1123

Open Peilin-Yang opened 1 year ago

Peilin-Yang commented 1 year ago

This PR introduces a simple fix to SketchMap's non-commutative, as illustrated in https://github.com/twitter/algebird/issues/1122

The fix is simply to always put the DenseMatrix as the first param so that the update to it is correct.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.23 :tada:

Comparison is base (f644ba4) 89.48% compared to head (abf56a8) 89.72%.

:exclamation: Current head abf56a8 differs from pull request most recent head 6b8610d. Consider uploading reports for the commit 6b8610d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1123 +/- ## =========================================== + Coverage 89.48% 89.72% +0.23% =========================================== Files 124 124 Lines 10028 10030 +2 Branches 782 774 -8 =========================================== + Hits 8974 8999 +25 + Misses 1054 1031 -23 ``` | [Impacted Files](https://app.codecov.io/gh/twitter/algebird/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=twitter) | Coverage Δ | | |---|---|---| | [...rc/main/scala/com/twitter/algebird/SketchMap.scala](https://app.codecov.io/gh/twitter/algebird/pull/1123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=twitter#diff-YWxnZWJpcmQtY29yZS9zcmMvbWFpbi9zY2FsYS9jb20vdHdpdHRlci9hbGdlYmlyZC9Ta2V0Y2hNYXAuc2NhbGE=) | `92.72% <100.00%> (+0.27%)` | :arrow_up: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/twitter/algebird/pull/1123/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=twitter)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.