search

twitter / cassovary

Cassovary is a simple big graph processing library for the JVM
http://twitter.com/cassovary
Apache License 2.0
1.05k stars 150 forks source link

Modify page rank to work with dangling nodes #187

Closed bmckown closed 9 years ago

bmckown commented 9 years ago

Apparently we did not handle dangling nodes at all in the implementation of page rank. This new implementation taken from here correctly handles dangling nodes.

This PR directly addresses #186

cc @pankajgupta cc @alexloginov

alexloginov commented 9 years ago

@bmckown It looks promising! BTW, what way is preferred: use dependency from maven or download jar from github releases?

pankajgupta commented 9 years ago

The two are in sync -- but using dependency from maven is always preferred.

On Wed, Jun 17, 2015 at 2:08 PM, Alexander Loginov <notifications@github.com

wrote:

@bmckown https://github.com/bmckown It looks promising! BTW, what way is preferred: use dependency from maven or download jar from github releases?

— Reply to this email directly or view it on GitHub https://github.com/twitter/cassovary/pull/187#issuecomment-112950116.

pankajgupta commented 9 years ago
  1. Let's use a BitSet explicitly. We are anyway indexing array by id. Default Set seems to be HashSet and I am concerned it might blow up in memory.
  2. Please add some one line comments for readability.

Looks good otherwise.

bmckown commented 9 years ago

Updated.