twitter / cassovary

Cassovary is a simple big graph processing library for the JVM
http://twitter.com/cassovary
Apache License 2.0
1.05k stars 150 forks source link

Inconsistency in Node API #225

Open lintool opened 7 years ago

lintool commented 7 years ago

If we look at the Node API, we have:

def randomOutboundNodeSet(numResults: Int, rnd: Random): Seq[Int]: https://github.com/twitter/cassovary/blob/master/cassovary-core/src/main/scala/com/twitter/cassovary/graph/Node.scala#L123

def outboundNodes(): CSeq[Int]: https://github.com/twitter/cassovary/blob/master/cassovary-core/src/main/scala/com/twitter/cassovary/graph/Node.scala#L89

Note that one returns a CSeq and the other returns a Seq. Should this be made consistent?

pankajgupta commented 7 years ago

Good catch. Will fix.