search

twitter / cassovary

Cassovary is a simple big graph processing library for the JVM
http://twitter.com/cassovary
Apache License 2.0
1.05k stars 150 forks source link

Build for Scala 2.11 #90

Closed chrisbeach closed 9 years ago

chrisbeach commented 9 years ago

Please could you release a build for Scala 2.11?

szymonm commented 9 years ago

@agrewal @pankajgupta Do you think we can move to 2.10/2.11 now?

I can do this.

pankajgupta commented 9 years ago

It is already for 2.10. Yes 2.11 is outstanding. On 18-Dec-2014 2:17 pm, "Szymon" notifications@github.com wrote:

@agrewal https://github.com/agrewal @pankajgupta https://github.com/pankajgupta Do you think we can move to 2.10/2.11 now?

— Reply to this email directly or view it on GitHub https://github.com/twitter/cassovary/issues/90#issuecomment-67456951.

szymonm commented 9 years ago

@agrewal @pankajgupta We miss the Twitter Ostrich for 2.11. Do you happen to know if we can expect it in the near future? @travisbrown maybe you know?

IIUC, Finagle had a similar problem and excluded subprojects that depend on Ostrich. See https://github.com/twitter/finagle/blob/master/project/Build.scala.

travisbrown commented 9 years ago

@szymonm Ostrich for 2.11 isn't released yet, but it's available in the develop branch and should be up on Maven Central soon (next week, I'd guess, but I can't promise).

szymonm commented 9 years ago

@travisbrown Thanks, that's great. Btw. what's the problem with specs2 and 2.11?

travisbrown commented 9 years ago

@szymonm Projects like Finagle were on specs (without the "2"), which isn't available for 2.11, and instead of moving to specs2 (which would require extensive changes for some projects), we decided to move all Twitter Scala projects directly to ScalaTest (with a specifically restricted use of the API).

szymonm commented 9 years ago

@travisbrown Thanks for your clarification.

So we have the same problem here. We will have to move all spec complaint tests to ScalaTest before going to 2.11. Any volounteers or ideas?

pankajgupta commented 9 years ago

See outstanding issue https://github.com/twitter/cassovary/issues/89 regarding Ostrich. Migration to scalatest is tracked in https://github.com/twitter/cassovary/issues/64

szymonm commented 9 years ago

Including PR in review #64 is done. We are waiting only for #89 - in progress.

szymonm commented 9 years ago

@AnishShah Are you currently working also on 2.11? If not, I can take care of it.

AnishShah commented 9 years ago

First we need to migrate from ostrich to metrics right? Currently doing that.. On 21 Jan 2015 02:37, "Szymon" notifications@github.com wrote:

@AnishShah https://github.com/AnishShah Are you currently working also on 2.11? If not, I can take care of it.

— Reply to this email directly or view it on GitHub https://github.com/twitter/cassovary/issues/90#issuecomment-70733612.

szymonm commented 9 years ago

Right, ok.

caniszczyk commented 9 years ago

This is now done through a combination of commits https://github.com/twitter/cassovary/commit/9135d0d7cda38d14183bca1e10fa8e968063e466