SmallBoundedPriorityQueueSpec migration to scalatest

twitter / cassovary

Cassovary is a simple big graph processing library for the JVM

http://twitter.com/cassovary

Apache License 2.0

1.05k stars 150 forks source link

SmallBoundedPriorityQueueSpec migration to scalatest #94

Closed bartekkalinka closed 9 years ago

bartekkalinka commented 9 years ago

Another test migration

szymonm commented 9 years ago

LGTM. @bartekkalinka Could you do a rebase and squash this 3 commits into one? @pankajgupta I think it's ready to merge after rebase.

bartekkalinka commented 9 years ago

Done

bartekkalinka commented 9 years ago

I don't think the "in" blocks were meant to be executed in parallel. For example, "not full" and "full" blocks were one sequential block before the modification, and the latter depends on the results from the former. So, should I:

somehow mark these "in" blocks for sequential execution (is it possible and how)?
redesign these tests so each "in" block can be executed in parallel (involves more changes than modifying val q)?

I had no idea I had to consider parallel execution here. Whole "when" blocks could be run in parallel now though (I think).

szymonm commented 9 years ago

I used fixtures here: https://github.com/twitter/cassovary/blob/master/cassovary-core/src/test/scala/com/twitter/cassovary/util/io/AdjacencyListGraphReaderSpec.scala

bartekkalinka commented 9 years ago

So "in" blocks should be independent of each other? I'll rewrite whole thing.

pankajgupta commented 9 years ago

yes, that is best practice.

bartekkalinka commented 9 years ago

Done, let me know what you think.

bartekkalinka commented 9 years ago

Seq works fine. Corrected test description.