twitter / compose-rules

Static checks to aid with a healthy adoption of Compose
https://twitter.github.io/compose-rules
Other
1.36k stars 93 forks source link

The future of this project #112

Open vitusortner opened 1 year ago

vitusortner commented 1 year ago

Given the current situation at Twitter, can we expect this library to still be maintained?

svenjacobs commented 1 year ago

Since both @mrmans0n and @chrisbanes left Twitter (sorry guys 😢), the future doesn't look so bright. At least not under Twitter's scope. Maybe this project can find a new home at Google, for instance?

mrmans0n commented 1 year ago

I'm thinking about forking it, but I need to look into the license and all that.

chrisbanes commented 1 year ago

You can fork easily with Apache 2.0: https://tldrlegal.com/license/apache-license-2.0-%28apache-2.0%29

You need to make sure you keep any existing license and copyright (headers), but you can add your own headers on top for modifications.

kenyee commented 1 year ago

+1 fork it unless we're locked out from merging PRs. Apache license should be fine :-)

On Sun, Nov 20, 2022 at 3:39 PM Chris Banes @.***> wrote:

You can fork easily with Apache 2.0: https://tldrlegal.com/license/apache-license-2.0-%28apache-2.0%29

You need to make sure you keep any existing license and copyright (headers), but you can add your own headers on top for modifications.

— Reply to this email directly, view it on GitHub https://github.com/twitter/compose-rules/issues/112#issuecomment-1321237515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPHLXSDGNY4O3FWL2ITALWJKEBJANCNFSM6AAAAAASBGKRYU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

ege-ah commented 1 year ago

+1 please fork @mrmans0n or assign it to Elon Musk idk

mrmans0n commented 1 year ago

I started my fork in https://github.com/mrmans0n/compose-rules

First order of business was supporting ktlint 0.48.x and kotlin 1.8.x. I submitted them as a PR in this repo too, to ease with transition, but I doubt anybody is looking on the Twitter side (all the admins of this repo don't work at the company any longer, and our permissions were removed).

I will work towards a maven central publication for my fork as soon as possible.

kenyee commented 1 year ago

LOL...they took away all of our approval permissions? 😹 🤦

kenyee commented 1 year ago

Yo Elon...not cool

digitalbuddha commented 1 year ago

I'd like to suggest moving the project to the mobile native foundation rather than your personal. This would allow you to move on someday with minimal changes

mrmans0n commented 1 year ago

It was much easier using my own, tbh (sonatype coordinates are already approved, plus setup is done). What's a compelling reason to use an org? (asking from my complete ignorance of what the mobile native foundation stands for, how it operates, etc 😅 )

LOL...they took away all of our approval permissions? 😹 🤦

Mine were removed at least, 100%. Can't do anything in this repo anymore. It's fair but still hurts a little given how much work I've put into this 🤣

digitalbuddha commented 1 year ago

It is under the Linux foundation. Mostly I thought it would help to decouple the project from any one person. I successfully moved a project there rather than personal when leaving Dropbox. It was a fairly simple process of signing one doc and telling them which maven coordinates I wanted.

I see this similar to a project moving to apache or some other foundation. No big advantage just planting seeds for a healthy future oss ecosystem

mrmans0n commented 1 year ago

Interesting, I will look into that then, GitHub can help me move the project when the time comes and it adds a redirection from the old URL to the new URL, so no biggie.

I was mostly interested from the technical standpoint what the maven coordinates would be for the dependency, so I moved the fork to use a domain I have permissions to publish on (which won't likely need to change) and I already got a version in maven central.

digitalbuddha commented 1 year ago

It would be something like org.mobilenativefoundation.composerules

Happy to discuss further or get ball rolling if there is interest.