search

twitter / fatcache

Memcache on SSD
Apache License 2.0
1.3k stars 178 forks source link

About expire time in fatcache #18

Closed git-hulk closed 7 years ago

git-hulk commented 9 years ago

hi @manju @thinkingfish

I have some questions:

  1. why not put expire time in itemx, as we have to use it frequently, and it may lead to read disk slab.
  2. why not add stats command for fatcache, as it may be useful.

Best Regards~

manjuraj commented 9 years ago

@git-hulk yeah both those suggestions make sense

git-hulk commented 9 years ago

thank you, @manjuraj I will try to make a patch for those. by the way, why the following code is discarded, and it cause quit command unusable. https://github.com/twitter/fatcache/blob/master/src/fc_request.c#L108

git-hulk commented 7 years ago

put the expire time to index was done, close this issue. pr: https://github.com/twitter/fatcache/pull/21