Closed alikemalocalan closed 4 years ago
Merging #867 into develop will decrease coverage by
0.02%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #867 +/- ##
===========================================
- Coverage 77.45% 77.43% -0.03%
===========================================
Files 814 814
Lines 24111 24111
Branches 1597 1599 +2
===========================================
- Hits 18676 18671 -5
- Misses 5435 5440 +5
Impacted Files | Coverage Δ | |
---|---|---|
...n/scala/com/twitter/finagle/http2/Exceptions.scala | 0.00% <0.00%> (-50.00%) |
:arrow_down: |
...gle/http2/transport/client/ClientSessionImpl.scala | 79.54% <0.00%> (-11.37%) |
:arrow_down: |
...gle/http2/transport/client/ClientServiceImpl.scala | 81.81% <0.00%> (-9.10%) |
:arrow_down: |
...com/twitter/finagle/netty4/ConnectionBuilder.scala | 75.80% <0.00%> (-1.62%) |
:arrow_down: |
.../com/twitter/finagle/tracing/BroadcastTracer.scala | 66.66% <0.00%> (ø) |
|
...om/twitter/finagle/dispatch/ServerDispatcher.scala | 85.10% <0.00%> (+2.12%) |
:arrow_up: |
...m/twitter/finagle/exp/ConcurrencyLimitFilter.scala | 91.42% <0.00%> (+2.85%) |
:arrow_up: |
...tter/finagle/dispatch/SerialClientDispatcher.scala | 100.00% <0.00%> (+16.66%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 80d119f...ec84e1f. Read the comment docs.
Hi @alikemalocalan, thanks for the submission. Sorry that I missed it earlier this week. I'm catching up on the details now.
@alikemalocalan, are you interested in addressing Ryan's feedback?
hi @bryce-anderson , i understood explanation of @ryanoneill , my solution isn't useful for like this project. Maybe next years , if you will find more simple sbt sub-module solution, i can help you :D
Problem Fixes #855
Explain the context and why you're making that change. What is the problem you're trying to solve? In some cases there is not a problem and this can be thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes this section is unnecessary because it is self-explanatory based on the solution.