Closed odidev closed 4 years ago
Merging #870 into develop will decrease coverage by
0.03%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #870 +/- ##
===========================================
- Coverage 78.22% 78.19% -0.04%
===========================================
Files 817 818 +1
Lines 24180 24237 +57
Branches 1579 1519 -60
===========================================
+ Hits 18916 18951 +35
- Misses 5264 5286 +22
Impacted Files | Coverage Δ | |
---|---|---|
...tter/finagle/dispatch/SerialClientDispatcher.scala | 83.33% <0.00%> (-16.67%) |
:arrow_down: |
.../com/twitter/finagle/tracing/BroadcastTracer.scala | 60.41% <0.00%> (-6.25%) |
:arrow_down: |
...rtitioning/ConsistentHashPartitioningService.scala | 95.00% <0.00%> (-5.00%) |
:arrow_down: |
...riftmux/service/ClientTraceAnnotationsFilter.scala | 91.66% <0.00%> (-4.17%) |
:arrow_down: |
...m/twitter/finagle/exp/ConcurrencyLimitFilter.scala | 88.57% <0.00%> (-2.86%) |
:arrow_down: |
...src/main/scala/com/twitter/finagle/Memcached.scala | 76.52% <0.00%> (-2.76%) |
:arrow_down: |
...ft/src/main/scala/com/twitter/finagle/Thrift.scala | 86.46% <0.00%> (-2.69%) |
:arrow_down: |
...src/main/scala/com/twitter/finagle/ThriftMux.scala | 86.41% <0.00%> (-2.41%) |
:arrow_down: |
...gle/http2/transport/client/RefCountedFactory.scala | 78.26% <0.00%> (-2.18%) |
:arrow_down: |
...http/src/main/scala/com/twitter/finagle/Http.scala | 84.47% <0.00%> (-2.16%) |
:arrow_down: |
... and 15 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aa612ef...5fa6bd2. Read the comment docs.
This generally looks reasonable, but why did you not choose to upgrade to netty 4.1.51.Final, which has been available since early July?
Merged as c4eb5bafd20295ed6f2bfc70ffd7e0e981437f14. Thanks!
Signed-off-by: odidev odidev@puresoftware.com