search

twitter / finagle

A fault tolerant, protocol-agnostic RPC system
https://twitter.github.io/finagle
Apache License 2.0
8.78k stars 1.45k forks source link

Fix link to SharedChannelStats in Scaladoc #877

Closed takezoe closed 3 years ago

takezoe commented 3 years ago

Link to SharedChannelStats in Scaladoc of ChannelStatsHandler is wrong.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 3 years ago

Codecov Report

Merging #877 (bfee039) into develop (67be8e1) will increase coverage by 1.34%. The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #877      +/-   ##
===========================================
+ Coverage    76.77%   78.12%   +1.34%     
===========================================
  Files          832      832              
  Lines        24546    24568      +22     
  Branches      1592     1588       -4     
===========================================
+ Hits         18845    19193     +348     
+ Misses        5701     5375     -326
Impacted Files Coverage Δ
...ore/src/main/scala/com/twitter/finagle/Stack.scala 76.51% <0.00%> (-0.59%) :arrow_down:
...witter/finagle/filter/ForwardingWarmUpFilter.scala 89.28% <ø> (ø)
...r/finagle/netty4/channel/ChannelStatsHandler.scala 96.84% <ø> (+13.68%) :arrow_up:
...e/thrift/filter/ThriftForwardingWarmUpFilter.scala 100.00% <ø> (ø)
...core/src/main/scala/com/twitter/finagle/Init.scala 82.00% <100.00%> (+0.36%) :arrow_up:
...cala/com/twitter/finagle/ServiceFactoryProxy.scala 100.00% <100.00%> (ø)
...twitter/finagle/client/EndpointerStackClient.scala 89.65% <100.00%> (+0.36%) :arrow_up:
...scala/com/twitter/finagle/client/StackClient.scala 98.46% <100.00%> (+0.07%) :arrow_up:
...m/twitter/finagle/exp/ConcurrencyLimitFilter.scala 0.00% <0.00%> (-91.43%) :arrow_down:
...witter/finagle/mux/pushsession/MessageWriter.scala 77.77% <0.00%> (-8.65%) :arrow_down:
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e725bc8...bfee039. Read the comment docs.

ryanoneill commented 3 years ago

Thank you for your contribution to Finagle, @takezoe. This has been submitted internally and pushed back out to GitHub as https://github.com/twitter/finagle/commit/34f4ddc8b75d58db3185fe01e178cf87768d2a7c.