search

twitter / finagle

A fault tolerant, protocol-agnostic RPC system
https://twitter.github.io/finagle
Apache License 2.0
8.78k stars 1.45k forks source link

The README file in this repo has a bad link - [404:NotFound] #879

Closed MrCull closed 3 years ago

MrCull commented 3 years ago

Problem

When clicking: “Open Source Code of Conduct” Status code [404:NotFound] - Link: https://github.com/twitter/code-of-conduct/blob/release/code-of-conduct.md

Issue #878

Solution

Link should work and I think it should point to here: https://github.com/twitter/code-of-conduct/blob/master/code-of-conduct.md

additional

This bad link was found by a tool I very recently created as part of an new experimental hobby project: https://github.com/MrCull/GitHub-Repo-ReadMe-Dead-Link-Finder

Re-check this Repo via: http://githubreadmechecker.com/Home/Search?SingleRepoUri=https%3A%2F%2Fgithub.com%2Ftwitter%2Ffinagle Check all Repos for this GitHub account: http://githubreadmechecker.com/Home/Search?User=twitter

If this has been in any way helpful then please consider giving the above Repo a Star. If you have any feedback on the information provided here, or on the tool itself, then please feel free to share your thoughts and pass on the feedback.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 3 years ago

Codecov Report

Merging #879 (5ec401d) into develop (9710eec) will increase coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #879      +/-   ##
===========================================
+ Coverage    78.12%   78.24%   +0.12%     
===========================================
  Files          832      833       +1     
  Lines        24557    24719     +162     
  Branches      1586     1604      +18     
===========================================
+ Hits         19184    19342     +158     
- Misses        5373     5377       +4
Impacted Files Coverage Δ
...ttp2/transport/client/Http2ClientEventMapper.scala 90.90% <0.00%> (-9.10%) :arrow_down:
...itter/finagle/liveness/FailureAccrualFactory.scala 93.33% <0.00%> (-5.13%) :arrow_down:
...twitter/finagle/service/PendingRequestFilter.scala 86.36% <0.00%> (-4.55%) :arrow_down:
...main/scala/com/twitter/finagle/stats/Metrics.scala 79.31% <0.00%> (-2.59%) :arrow_down:
...om/twitter/finagle/dispatch/ServerDispatcher.scala 82.97% <0.00%> (-2.13%) :arrow_down:
.../com/twitter/finagle/service/BackoffStrategy.scala 76.08% <0.00%> (ø)
...oning/ConsistentHashingFailureAccrualFactory.scala 84.61% <0.00%> (+0.94%) :arrow_up:
...ter/finagle/mux/pushsession/MuxClientSession.scala 92.92% <0.00%> (+1.01%) :arrow_up:
.../com/twitter/finagle/tracing/BroadcastTracer.scala 68.75% <0.00%> (+2.08%) :arrow_up:
...cala/com/twitter/finagle/service/RetryPolicy.scala 81.11% <0.00%> (+2.10%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9710eec...5ec401d. Read the comment docs.

ryanoneill commented 3 years ago

Thank you very much for your contribution @MrCull. This has been submitted internally and pushed back out to GitHub as https://github.com/twitter/finagle/commit/e169f083d6d2721bf6ae431fa9f0db3370960330