search

twitter / finagle

A fault tolerant, protocol-agnostic RPC system
https://twitter.github.io/finagle
Apache License 2.0
8.78k stars 1.45k forks source link

Upgrade to netty 4.1.56.Final and netty-tcnative 2.0.35.Final #884

Closed peter-janssen closed 3 years ago

peter-janssen commented 3 years ago

Problem

There are new netty releases and the classifier for AArch64 was changed from linux-aarch64 to linux-aarch_64. This results in dependency problems with other projects.

Solution

Upgrade to netty 4.1.56.Final and netty-tcnative 2.0.35.Final for security fixes and AArch64 dependency rename.

https://netty.io/news/2020/12/17/4-1-55-Final.html https://netty.io/news/2020/12/17/4-1-56-Final.html

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 3 years ago

Codecov Report

Merging #884 (8067ec4) into develop (debefa8) will decrease coverage by 0.43%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #884      +/-   ##
===========================================
- Coverage    78.33%   77.90%   -0.44%     
===========================================
  Files          836      837       +1     
  Lines        24776    24968     +192     
  Branches      1579     1593      +14     
===========================================
+ Hits         19409    19451      +42     
- Misses        5367     5517     +150
Impacted Files Coverage Δ
...er/finagle/partitioning/PartitionNodeManager.scala 53.16% <0.00%> (-30.93%) :arrow_down:
...ore/src/main/scala/com/twitter/finagle/Stack.scala 48.41% <0.00%> (-28.10%) :arrow_down:
...tter/finagle/loadbalancer/TrafficDistributor.scala 65.53% <0.00%> (-28.02%) :arrow_down:
...main/scala/com/twitter/finagle/stats/Metrics.scala 79.31% <0.00%> (-2.59%) :arrow_down:
...om/twitter/finagle/dispatch/ServerDispatcher.scala 82.97% <0.00%> (-2.13%) :arrow_down:
...witter/finagle/http/filter/HttpTracingFilter.scala 94.44% <0.00%> (ø)
...ain/scala/com/twitter/finagle/http/TraceInfo.scala 86.66% <0.00%> (+0.09%) :arrow_up:
...http/src/main/scala/com/twitter/finagle/Http.scala 84.66% <0.00%> (+0.19%) :arrow_up:
...ter/finagle/mux/pushsession/MuxClientSession.scala 92.92% <0.00%> (+1.01%) :arrow_up:
...2/transport/common/Http2StreamMessageHandler.scala 94.87% <0.00%> (+2.56%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update debefa8...8067ec4. Read the comment docs.

bryce-anderson commented 3 years ago

This is getting hung up on some changes in TLS behavior. See here for more details.

bryce-anderson commented 3 years ago

@peter-janssen, the patch to fix the ticket mentioned above should be in so we'll need to wait for another release before we can upgrade. Thanks for the PR, and once a release happens please feel free to submit another PR if we haven't already gotten around to it.