search

twitter / finagle

A fault tolerant, protocol-agnostic RPC system
https://twitter.github.io/finagle
Apache License 2.0
8.78k stars 1.45k forks source link

upgrade netty to incorporate new aarch_64 classifier #891

Closed bpholt closed 3 years ago

bpholt commented 3 years ago

Problem

This is a refresh of #884: "There are new netty releases and the classifier for AArch64 was changed from linux-aarch64 to linux-aarch_64. This results in dependency problems with other projects."

884 was blocked because of a bug in netty 4.1.56.Final, but AFAICT this has been fixed in 4.1.59.Final.

Solution

Upgrade to netty 4.1.59.Final and netty-tcnative 2.0.35.Final for security fixes and AArch64 dependency rename.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 3 years ago

Codecov Report

Merging #891 (cce7c28) into develop (cb3b6b2) will increase coverage by 0.11%. The diff coverage is 77.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #891      +/-   ##
===========================================
+ Coverage    78.41%   78.52%   +0.11%     
===========================================
  Files          841      841              
  Lines        24872    24914      +42     
  Branches      1614     1608       -6     
===========================================
+ Hits         19503    19564      +61     
+ Misses        5369     5350      -19
Impacted Files Coverage Δ
...ala/com/twitter/finagle/filter/OffloadFilter.scala 78.43% <0.00%> (-3.21%) :arrow_down:
...itter/finagle/loadbalancer/aperture/Aperture.scala 72.95% <75.00%> (+2.25%) :arrow_up:
.../twitter/finagle/http/exp/routing/HttpRouter.scala 81.13% <81.13%> (ø)
...ttp2/transport/client/Http2ClientEventMapper.scala 90.90% <0.00%> (-9.10%) :arrow_down:
.../com/twitter/finagle/tracing/BroadcastTracer.scala 62.50% <0.00%> (-8.34%) :arrow_down:
...main/scala/com/twitter/finagle/tracing/Trace.scala 89.77% <0.00%> (-4.13%) :arrow_down:
...cala/com/twitter/finagle/service/RetryPolicy.scala 76.54% <0.00%> (-1.78%) :arrow_down:
...scala/com/twitter/finagle/param/ClientParams.scala 50.00% <0.00%> (ø)
...la/com/twitter/finagle/builder/ClientBuilder.scala 64.84% <0.00%> (ø)
...a/com/twitter/finagle/serverset2/RetryStream.scala 100.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 736c361...cce7c28. Read the comment docs.

bpholt commented 3 years ago

@bryce-anderson do you think this will get into the 21.3 release?

jyanJing commented 3 years ago

Hi @bpholt I will pull it in and run some tests!

jyanJing commented 3 years ago

Hi @bpholt , some updates: I pulled your branch and I am in the process of testing it. I will be OOO Monday and Tuesday, but I will come back to it on Wednesday. As long as I am able to merge this change in March it will be in the 21.3 release 🤞 Thank you working on it!

jyanJing commented 3 years ago

Some updates: I completed most of the testings and the results look good! I am working on the last piece of testing and currently running into some environment issues, this is not related to the change, I will need to get some help from other teams to resolve it, will come back to it on Monday! Thank you for your patience!

jyanJing commented 3 years ago

The change just merged. Thank you for working on it @bpholt !