search

twitter / finagle

A fault tolerant, protocol-agnostic RPC system
https://twitter.github.io/finagle
Apache License 2.0
8.79k stars 1.46k forks source link

Typo `ahere` changed to `adhere` #895

Closed dainmiller closed 3 years ago

dainmiller commented 3 years ago

Simple typo fix

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

codecov-io commented 3 years ago

Codecov Report

Merging #895 (e0666a1) into develop (a1a2502) will decrease coverage by 34.69%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #895       +/-   ##
============================================
- Coverage    76.10%   41.40%   -34.70%     
============================================
  Files          847      846        -1     
  Lines        24995    24930       -65     
  Branches      1557     1566        +9     
============================================
- Hits         19023    10323     -8700     
- Misses        5972    14607     +8635
Impacted Files Coverage Δ
...rc/main/scala/com/twitter/finagle/http/Route.scala 0.00% <0.00%> (-100.00%) :arrow_down:
.../main/scala/com/twitter/finagle/util/NetUtil.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...in/scala/com/twitter/finagle/ssl/TlsSnooping.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...ain/scala/com/twitter/finagle/http2/Settings.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...n/scala/com/twitter/finagle/ssl/CipherSuites.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...rc/main/scala/com/twitter/finagle/stats/Glob.scala 0.00% <0.00%> (-100.00%) :arrow_down:
.../scala/com/twitter/finagle/exp/routing/Route.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...n/scala/com/twitter/finagle/mysql/Capability.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...cala/com/twitter/finagle/param/SessionParams.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...main/scala/com/twitter/finagle/stats/package.scala 0.00% <0.00%> (-100.00%) :arrow_down:
... and 543 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1a2502...e0666a1. Read the comment docs.

dotordogh commented 3 years ago

Hi @dainmiller, thank you for the PR! I'm happy to merge this in!

dainmiller commented 3 years ago

Thanks! Context: I'm building a typo tool that crawls github for typos - hope to find more in the future!! Haha :) cc @dotordogh