Testing the merge: Attempt 1/N

[vkostyukov]

We're testing to see how easy it is to merge finagle-postgres in.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
12 out of 14 committers have signed the CLA.

:white_check_mark: clhodapp
:white_check_mark: andrerigon
:white_check_mark: dangerousben
:white_check_mark: vkostyukov
:white_check_mark: crispywalrus
:white_check_mark: plaflamme
:white_check_mark: ben-healthforge
:white_check_mark: leonmaia
:white_check_mark: jilen
:white_check_mark: steveniemitz
:white_check_mark: juliano
:white_check_mark: scala-steward
:x: jeremyrsmith
:x: afine
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[vkostyukov]

@jeremyrsmith @clhodapp @jilen @ben-healthforge @afine @leonmaia @andrerigon @dangerousben @crispywalrus @plaflamme @juliano

Folks, do you mind signing the CLA? We require all Finagle contributors to sign it.

[plaflamme]

FWIW: I have a different (and more modern) implementation of Postgres on finagle here. It's closer to the existing mysql client, so perhaps a better candidate for merging into finagle mainline. It's unfortunately incomplete yet: lacking transactions and a proper Cursor implementation like finagle-mysql client has. I'm happy to help investigate the feasibility of using this alternate implementation.

[codecov-commenter]

Codecov Report

Merging #904 (043a13c) into develop (bc05a2a) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 043a13c differs from pull request most recent head 8e3a8fd. Consider uploading reports for the commit 8e3a8fd to get more accurate results

@@             Coverage Diff             @@
##           develop     #904      +/-   ##
===========================================
- Coverage    78.25%   78.23%   -0.02%     
===========================================
  Files          879      879              
  Lines        25473    25473              
  Branches      1624     1569      -55     
===========================================
- Hits         19934    19929       -5     
- Misses        5539     5544       +5     

Impacted Files	Coverage Δ
...n/scala/com/twitter/finagle/http2/Exceptions.scala	0.00% <0.00%> (-50.00%)	:arrow_down:
...gle/http2/transport/client/ClientSessionImpl.scala	79.54% <0.00%> (-11.37%)	:arrow_down:
...gle/http2/transport/client/ClientServiceImpl.scala	81.81% <0.00%> (-9.10%)	:arrow_down:
.../com/twitter/finagle/tracing/BroadcastTracer.scala	45.83% <0.00%> (-4.17%)	:arrow_down:
...r/finagle/dispatch/GenSerialClientDispatcher.scala	79.31% <0.00%> (-3.45%)	:arrow_down:
...m/twitter/finagle/exp/ConcurrencyLimitFilter.scala	88.57% <0.00%> (-2.86%)	:arrow_down:
...om/twitter/finagle/dispatch/ServerDispatcher.scala	85.10% <0.00%> (+2.12%)	:arrow_up:
...gle/http2/transport/client/RefCountedFactory.scala	80.43% <0.00%> (+2.17%)	:arrow_up:
...com/twitter/finagle/netty4/ConnectionBuilder.scala	79.03% <0.00%> (+3.22%)	:arrow_up:
...twitter/finagle/service/PendingRequestFilter.scala	90.90% <0.00%> (+4.54%)	:arrow_up:
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc05a2a...8e3a8fd. Read the comment docs.

[steveniemitz]

opened a new PR #908 for try 2 on this w/ finagle-postgresql.

[bryce-anderson]

This has been merged.