Closed gokyo closed 2 years ago
Merging #916 (f34dbc8) into develop (ad0c9d1) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #916 +/- ##
========================================
Coverage 63.89% 63.89%
========================================
Files 947 947
Lines 32083 32083
Branches 2102 2107 +5
========================================
+ Hits 20500 20501 +1
+ Misses 11583 11582 -1
Impacted Files | Coverage Δ | |
---|---|---|
...riftmux/pushsession/MuxDowngradingNegotiator.scala | 90.32% <100.00%> (ø) |
|
...gle/http2/transport/client/ClientServiceImpl.scala | 81.81% <0.00%> (-9.10%) |
:arrow_down: |
.../com/twitter/finagle/tracing/BroadcastTracer.scala | 64.58% <0.00%> (-2.09%) |
:arrow_down: |
...gle/http2/transport/client/ClientSessionImpl.scala | 88.67% <0.00%> (-1.89%) |
:arrow_down: |
...tter/finagle/redis/protocol/commands/Streams.scala | 97.53% <0.00%> (-1.24%) |
:arrow_down: |
...n/scala/com/twitter/finagle/memcached/Client.scala | 50.61% <0.00%> (+0.41%) |
:arrow_up: |
...twitter/finagle/service/PendingRequestFilter.scala | 90.90% <0.00%> (+4.54%) |
:arrow_up: |
.../http/exp/GenStreamingSerialServerDispatcher.scala | 77.08% <0.00%> (+6.25%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ad0c9d1...f34dbc8. Read the comment docs.
Hi @gokyo, Can you sign the Contributor License Agreement (CLA)? We need this before we can merge your PR. Thanks!
Hi @gokyo, Please sign the Contributor License Agreement (CLA) if you're interested in getting this PR merged. Thank you!
Hi @gokyo, can you please sign the CLA? Otherwise we cannot accept this PR.
@gokyo, I'm closing this PR. We cannot accept contributions without a CLA. Please re-open it when you sign the CLA. Thank you!
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.