search

twitter / finagle

A fault tolerant, protocol-agnostic RPC system
https://twitter.github.io/finagle
Apache License 2.0
8.78k stars 1.45k forks source link

Add MinSendBackupAfterMs to config in BackupRequestFilter #923

Closed emilhotkowski closed 2 years ago

emilhotkowski commented 2 years ago

Problem

The MinSendBackupAfterMs is now set to 1 ms. Unfortunately this causes backup requests to be send when there is low load.

Solution

Added MinSendBackupAfterMs to the stack param Configured in BackupRequestFilter and propagated changes to MethodBuilder by adding new versions of idempotent function.

Result

Developers will be able to set their own value of MinSendBackupAfterMs if necessary.

Closes twitter/finagle#905

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

tigerlily-he commented 2 years ago

First, can you add a PR description that follows this format? https://github.com/twitter/finagle/blob/develop/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

This will become the commit message when it is merged.

emilhotkowski commented 2 years ago

@tigerlily-he done!

jyanJing commented 2 years ago

It looks like the pr is already pulled and merging in progress internally, please ignore my comments, sorry about it!