DeadlineFilter takes `rejectWithdrawal` regardless of passed Deadline

twitter / finagle

A fault tolerant, protocol-agnostic RPC system

https://twitter.github.io/finagle

Apache License 2.0

8.78k stars 1.45k forks source link

DeadlineFilter takes `rejectWithdrawal` regardless of passed Deadline #936

Closed DieBauer closed 8 months ago

DieBauer commented 1 year ago

Describe the bug The DeadlineFilter will always take a rejectWithdrawal (default 5000) amount of tokens, while only restoring serviceDeposit (default 1000 tokens), in case rejection is not required.

Expected behavior Tokens get only withdrawn when the deadline is truly passed, as it was before the Traceability PR.

Additional context https://github.com/twitter/finagle/blob/develop/finagle-core/src/main/scala/com/twitter/finagle/service/DeadlineFilter.scala#L283

xin301x commented 1 year ago

这是来自QQ邮箱的假期自动回复邮件。您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。