ResponseBuilder.fileOrIndex doesn't check when file exists or not

[AlexITC]

ResponseBuilder.fileOrIndex(file, index) doesn't validate when file exists.

Expected behavior

When file doesn't exists, Finatra should provide index.

Actual behavior

The method fileOrIndex provides file when the file name contains a file extension and doesn't validate its existence.

In this case the file name can have a valid extension and don't be present in the file system, causing Finatra to return http status 404 (Not found).

Steps to reproduce the behavior

• Run Finatra application having a controller for serving files like the following:

  get("/:*") { request: Request =>
    response.ok.fileOrIndex(
      filePath = request.params("*"),
      indexPath = "index.html")
  }

• Ensure 'notafile.txt' doesn't exists.
• Do the following request: GET http://localhost:8888/notafile.txt
• You will get the following: HTTP/1.1 404 Not Found

[AlexITC]

The expected behavior I wrote is what I understand the method should do.

If this is the case, I would be happy to send a pull request.

Can someone confirm?

Thanks.

[ryanoneill]

Hi @AlexITC, thanks for the submission. In my opinion, it should return the index page as well, and not a 404. I'm currently checking our internal codebase to ensure that changing the semantics here will not break existing code. I'm also going to get the opinion of a few other folks here before proceeding. Thanks.

[AlexITC]

I've finally updated my pull request with some tests.