search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 410 forks source link

Client updates #455

Closed toropeza closed 5 years ago

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 7 committers have signed the CLA.

:white_check_mark: cacoco
:white_check_mark: locknic
:white_check_mark: sdalo2
:x: dhensche
:x: murph
:x: jenkins@bigbird
:x: toropeza

jenkins@bigbird seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

toropeza commented 6 years ago

@cacoco @nepthar

cacoco commented 6 years ago

@toropeza just FYI it looks like the code isn't building (the TravisCI job is failing -- it's linked to the PR above). Take a look! It would be good to have a clean build on the PR if possible.

bryce-anderson commented 6 years ago

It looks like this is essentially a duplicate of https://github.com/twitter/finatra/pull/456, with a little less code in HttpClientBuilder.scala. Should this be closed in favor of 456, or vise-versa?