danabananarama commented 6 years ago

Problem

When EmbeddedTwitterServer's logging method info was moved into the package object, the ability to suppress the calls in the base class disappeared.

Solution

Pass disableLogging into those calls so that logging is suppressed.

Result

EmbeddedTwitterServer's logging may be disabled in tests.

codecov-io commented 6 years ago

Codecov Report

Merging #457 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #457   +/-   ##
========================================
  Coverage    94.53%   94.53%           
========================================
  Files          228      228           
  Lines         3406     3406           
  Branches       251      251           
========================================
  Hits          3220     3220           
  Misses         186      186

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d616734...152d31a. Read the comment docs.

cacoco commented 6 years ago

@danabananarama thanks for the PR, we'll take a look!

cacoco commented 6 years ago

Merged in 483e78a6b478705bd85d0b57b145c5301d64d11e

danabananarama commented 6 years ago

Awesome, thanks!

twitter / finatra

Pass in disableLogging flag to EmbeddedTwitterServer logging calls #457

Codecov Report