Upgrade to sbt 1.2.8 - Githubissues

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle

https://twitter.github.io/finatra/

Apache License 2.0

2.27k stars 406 forks source link

Upgrade to sbt 1.2.8 #493

Closed xerial closed 5 years ago

xerial commented 5 years ago

Problem

sbt-1.1.x series have many bugs (including class loader bugs, etc.). Using the latest version is preferred to avoid hitting its bugs. https://www.scala-sbt.org/1.0/docs/sbt-1.1-Release-Notes.html

Solution

Upgraded to sbt 1.2.8

Result

I believe sbt-1.2.x series has no backward incompatible changes to sbt-1.1.x, so we can keep using the same sbt plugins.

cacoco commented 5 years ago

@xerial we'd like to keep this in sync with our other projects: Twitter Util, Scrooge, Finagle, and TwitterServer so we may not accept this as we'd like to do all of the projects at the same time in our monorepo.

Thank you for the PR, I'll see if I can push the team to update all of our projects in this manner.

cacoco commented 5 years ago

@xerial merged in 6b67b251775f3aa539a30868c75501491fc5b030