twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 406 forks source link

Problems with 19.5.0 finatra build #502

Closed viktortnk closed 5 years ago

viktortnk commented 5 years ago

I've got a compilation error while building one of our projects after updating the dependency to 19.5.0:

Symbol 'type com.twitter.finatra.http.RouteHint' is missing from the classpath.
                       [error] This symbol is required by 'value com.twitter.finatra.http.EmbeddedHttpServer.routeHint'.
                       [error] Make sure that type RouteHint is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
                       [error] A full rebuild may help if 'EmbeddedHttpServer.class' was compiled against an incompatible version of com.twitter.finatra.http.
                       [error]     val response = server.httpGetJson[ChangelogResponse](

I assume the RouteHint it should be in finatra-http_2.12-19.5.0-tests.jar archive, but I can't see it there

Any chance there was a problem with build?

cacoco commented 5 years ago

@viktortnk yep, looks like it didn't get wired up properly in the build.sbt file. I'll let the team know and we'll most likely cut a 19.5.1 release. Thanks!

ryanoneill commented 5 years ago

I cut a 19.5.1 release last night, and this should now be fixed. Thanks!

viktortnk commented 5 years ago

thanks, got everything working now

ryanoneill commented 5 years ago

Glad to hear that @viktortnk. Thanks for reporting the issue.