twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 406 forks source link

Fix project references in Readme.md #505

Closed guillaume-chech closed 5 years ago

guillaume-chech commented 5 years ago

Fix project name reference in Readme.md to adapt to new new in build.sbt

Problem

When running command to build or run project describe in Readme project reference helloWorld is outdated and does not corresponds to the on in build.sbt.

Solution

Change project reference from helloWorld to exampleHttpServer

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 5 years ago

Codecov Report

Merging #505 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #505   +/-   ##
========================================
  Coverage    92.35%   92.35%           
========================================
  Files          250      250           
  Lines         4001     4001           
  Branches       292      292           
========================================
  Hits          3695     3695           
  Misses         306      306

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60b5d3f...2f5718a. Read the comment docs.

yufangong commented 5 years ago

Thanks, @guillaume-chech, this is merged https://github.com/twitter/finatra/commit/5223c84d5f92a90680131c95aa035b7e996f31ce.