twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 406 forks source link

DO NOT MERGE: test sbt build #506

Closed bryce-anderson closed 5 years ago

bryce-anderson commented 5 years ago

See if things work.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 5 years ago

Codecov Report

Merging #506 into develop will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #506      +/-   ##
==========================================
- Coverage    92.35%   92.3%   -0.05%     
==========================================
  Files          250     250              
  Lines         4001    3938      -63     
  Branches       292     288       -4     
==========================================
- Hits          3695    3635      -60     
+ Misses         306     303       -3
Impacted Files Coverage Δ
.../finatra/thrift/internal/ThriftMethodService.scala 80% <0%> (-5.72%) :arrow_down:
.../com/twitter/finatra/json/utils/JsonDiffUtil.scala 89.47% <0%> (-1.01%) :arrow_down:
.../com/twitter/finatra/http/routing/HttpRouter.scala 93.9% <0%> (-0.42%) :arrow_down:
...a/com/twitter/finatra/thrift/routing/routers.scala 84.21% <0%> (-0.41%) :arrow_down:
...ch/qos/logback/core/LogbackAsyncAppenderBase.scala 94.23% <0%> (-0.32%) :arrow_down:
...internal/marshalling/RequestInjectableValues.scala 96.87% <0%> (-0.19%) :arrow_down:
...pp/src/main/scala/com/twitter/inject/app/App.scala 98% <0%> (-0.12%) :arrow_down:
...rnal/caseclass/jackson/CaseClassDeserializer.scala 93.69% <0%> (-0.06%) :arrow_down:
...main/scala/com/twitter/finatra/http/RouteDSL.scala 94.94% <0%> (-0.06%) :arrow_down:
.../com/twitter/finatra/http/request/MediaRange.scala 97.1% <0%> (-0.05%) :arrow_down:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60b5d3f...e0af3c5. Read the comment docs.

enbnt commented 5 years ago

Chatted with @bryce-anderson and we're going to close this out.