junhoi-pk
commented
5 years ago lazy val xxxClient = XXXHttpClientBuilder.build(
conf.getString("services.xxx.label"),
conf.getString("services.xxx.host"),
conf.getInt("services.xxx.port"),
conf.getBoolean("services.xxx.ssl")
)
-----------------------------------------------
object XXXHttpClientBuilder {
def build(label: String, host: String, port: Int = 80, ssl: Boolean = false, requestTimeout: Duration = 3.seconds) = {
val httpClientModule = new HttpClientModule {
override def dest = s"$host:$port"
override def defaultHeaders: Map[String, String] = Map("Host" -> host)
def buildHttpClient(mapper: FinatraObjectMapper, httpService: Service[Request, Response]): XXXHttpClient = {
new XXXHttpClient(
hostname = hostname,
httpService = httpService,
retryPolicy = retryPolicy,
defaultHeaders = defaultHeaders,
mapper = mapper
)
}
}
val httpClient = ssl match {
case false =>
Http.client
.withLabel(label)
.withTracer(XXXServerMain.injector.instance[HttpZipkinTracer])
.withSessionQualifier.noFailFast
.withRequestTimeout(requestTimeout)
.newClient(s"$host:$port")
.toService
case true =>
Http.client
.withLabel(label)
.withTracer(XXXServerMain.injector.instance[HttpZipkinTracer])
.withSessionQualifier.noFailFast
.withRequestTimeout(requestTimeout)
.withTls(host)
.newClient(s"$host:$port")
.toService
}
val masked = new MaskCancelFilter[Request, Response]
val maskedClient = masked.andThen(httpClient)
httpClientModule.buildHttpClient(
XXXServerMain.injector.instance[FinatraObjectMapper],
masked.andThen(maskedClient)
)
}
}
-----------------------------------------------
class XXXHttpClient(
hostname: String = "",
httpService: Service[Request, Response],
retryPolicy: Option[RetryPolicy[Try[Response]]] = None,
defaultHeaders: Map[String, String] = Map(),
mapper: FinatraObjectMapper) extends HttpClient(hostname, httpService, retryPolicy, defaultHeaders, mapper) {
override def execute(request: Request): Future[Response] = {
val res: Future[Response] = super.execute(request)
res.map {
httpResponse =>
if(httpResponse.status == Status.InternalServerError)
MDC.put("errorResponse", s"uri:${request.uri}, code:${httpResponse.statusCode}, body:${httpResponse.contentString} ")
}
res
}
}
cacoco
roanta
bryce-anderson
HttpClientModule rarely throws a
ChannelClosedException. The finatra version I use is 18.1.0 (But version 18.12.0 also had issues.)It didn't happen when there was a lot of traffic, and the remote server didn't have a problem.
Below is the stack trace