Jackson 2.10 support - Githubissues

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle

https://twitter.github.io/finatra/

Apache License 2.0

2.27k stars 406 forks source link

Jackson 2.10 support #511

Closed kimxogus closed 4 years ago

kimxogus commented 4 years ago

Support jackson 2.10

Expected behavior

Support jackson 2.10

Actual behavior

jackson 2.10 is not supported

Steps to reproduce the behavior

Add jackson 2.10.0 to library dependencies

"com.fasterxml.jackson.core"     % "jackson-core"          % "2.10.0",
"com.fasterxml.jackson.core"     % "jackson-databind"      % "2.10.0",
"com.fasterxml.jackson.module"   %% "jackson-module-scala" % "2.10.0",
"com.fasterxml.jackson.datatype" % "jackson-datatype-joda" % "2.10.0"

Compile error at https://github.com/twitter/finatra/blob/develop/jackson/src/main/scala/com/fasterxml/jackson/databind/ObjectMapperCopier.scala#L3
- Because of https://github.com/FasterXML/jackson-module-scala/commit/6e38b81e4680c153b21d92d81ce418307e9d26c1

enbnt commented 4 years ago

Jackson support has been updated to 2.10.1 in the develop branch - https://github.com/twitter/finatra/commit/dc7072e53961407647d5bf22381a47316f278e62.

cacoco commented 4 years ago

We've had to revert this upgrade and are working to move to Jackson 2.9.10.1 instead of 2.10.1 which should mitigate all open CVEs.

ryanoneill commented 4 years ago

We've upgraded to 2.9.10(.1) on the develop branch, and will be doing a release most likely within the week.

ryanoneill commented 4 years ago

As a further update, it's likely going to be a while before we can attempt to move Finatra to 2.10.1 again. There are some current internal blockers which need additional work, and I'm not sure yet when that will happen (as a different team is responsible there). We'll keep folks updated here when there's additional news. Thanks for your patience.

kimxogus commented 4 years ago

Thanks for updates 👍

cacoco commented 4 years ago

Finatra has been updated to Jackson 2.11 in e265ba87c5ff6cecc88b65dd050e0cf1a23df698. This should be in the next release: 20.5.0.

cacoco commented 4 years ago

Released in 20.5.0.