search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 406 forks source link

[DO NOT MERGE] finatra: Fix Test Logging dependencies #516

Closed cacoco closed 4 years ago

cacoco commented 4 years ago

DO NOT MERGE

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #516 into develop will increase coverage by 0.38%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #516      +/-   ##
===========================================
+ Coverage    90.96%   91.34%   +0.38%     
===========================================
  Files          265      265              
  Lines         4206     4206              
  Branches       310      298      -12     
===========================================
+ Hits          3826     3842      +16     
+ Misses         380      364      -16
Impacted Files Coverage Δ
...a/com/twitter/finatra/thrift/routing/routers.scala 88.03% <0%> (+3.41%) :arrow_up:
...ter/finatra/http/filters/AccessLoggingFilter.scala 85.71% <0%> (+57.14%) :arrow_up:
...r/finatra/thrift/filters/AccessLoggingFilter.scala 100% <0%> (+61.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 445ddf8...3c8458d. Read the comment docs.