search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 406 forks source link

httpAnnotations/jsonAnnotations: Cross-build for 2.13 #528

Closed chrisbenincasa closed 4 years ago

chrisbenincasa commented 4 years ago

Depends on #527

Problem

httpAnnotations and jsonAnnotations were not cross-built for Scala 2.13.

Solution

Add SBT settings and rules to enable cross-building and cross build these two modules.

Result

httpAnnotations and jsonAnnotations are cross-built for Scala 2.13.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

chrisbenincasa commented 4 years ago

JVM 11 failure in the build seems like https://github.com/twitter/finagle/issues/832

codecov[bot] commented 4 years ago

Codecov Report

Merging #528 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #528   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files          267      267           
  Lines         4779     4779           
  Branches       302      302           
========================================
  Hits          4337     4337           
  Misses         442      442

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 256284c...d216e94. Read the comment docs.

yufangong commented 4 years ago

Thanks! merged at 5fc7b3bce8d679571c6d7347a2a0db7eed989926