chrisbenincasa commented 4 years ago

Depends on #528

Problem

inject-slf4j is not cross-built for Scala 2.13.

Solution

Update inject-slf4j module to cross-build for Scala 2.13 using new SBT settings.

Result

inject-slf4j is cross-built for Scala 2.13.

CLAassistant commented 4 years ago

All committers have signed the CLA.

chrisbenincasa commented 4 years ago

JVM 11 failure in the build seems like https://github.com/twitter/finagle/issues/832

codecov[bot] commented 4 years ago

Codecov Report

Merging #529 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #529   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files          267      267           
  Lines         4779     4779           
  Branches       302      302           
========================================
  Hits          4337     4337           
  Misses         442      442

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5fc7b3b...06c98b0. Read the comment docs.

yufangong commented 4 years ago

Merged at https://github.com/twitter/finatra/commit/4b78bd5fcaef07fed205dad18402e63eb59b3a60, thanks!

twitter / finatra

inject-slf4j: Cross-build for Scala 2.13 #529

Codecov Report