search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 406 forks source link

inject-modules/inject-stack: Cross-build for 2.13 #531

Closed chrisbenincasa closed 4 years ago

chrisbenincasa commented 4 years ago

Depends on #530

Problem

inject-modules and inject-stack are not cross-built for Scala 2.13.

Solution

Update inject-modules and inject-stack modules to cross-build for Scala 2.13 using new SBT settings.

Result

inject-modules and inject-stack are cross-built for Scala 2.13.

yufangong commented 4 years ago

merged at https://github.com/twitter/finatra/commit/b5763ef9477d37e2fbd97dfd1c8ff9b32a350247. Thanks!

chrisbenincasa commented 4 years ago

Thanks @yufangong - just want to make sure you saw my comment here: https://github.com/twitter/finatra/pull/531#discussion_r484954001 . Is the scalafmt configuration for this repo available?

yufangong commented 4 years ago

@chrisbenincasa I indeed missed it, sorry. I'll do some research to see if we can enable scalafmt for oss directories. Thank you!