Closed chrisbenincasa closed 4 years ago
Merging #532 into develop will decrease coverage by
0.01%
. The diff coverage is92.30%
.
@@ Coverage Diff @@
## develop #532 +/- ##
===========================================
- Coverage 90.75% 90.73% -0.02%
===========================================
Files 267 267
Lines 4779 4780 +1
Branches 301 297 -4
===========================================
Hits 4337 4337
- Misses 442 443 +1
Impacted Files | Coverage Δ | |
---|---|---|
...ain/scala/com/twitter/inject/conversions/seq.scala | 76.92% <50.00%> (-6.42%) |
:arrow_down: |
...cala/com/twitter/inject/conversions/iterable.scala | 100.00% <100.00%> (ø) |
|
...ain/scala/com/twitter/inject/conversions/map.scala | 100.00% <100.00%> (ø) |
|
.../scala/com/twitter/inject/conversions/option.scala | 100.00% <100.00%> (ø) |
|
...n/scala/com/twitter/inject/conversions/tuple.scala | 94.11% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update abb72f4...6a33104. Read the comment docs.
Depends on #530
Problem
injectUtils was not cross-built for Scala 2.13.
Solution
Add SBT setting to enable 2.13 cross-build for injectUtils
NOTE This has some of the first usages of the Scala collection compat library. https://github.com/twitter/finagle/issues/818 will probably be relevant here due to some of the changes.
Result
injectUtils cross-built for Scala 2.13.