search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.28k stars 409 forks source link

inject-ports: Cross-build for Scala 2.13 #533

Closed chrisbenincasa closed 4 years ago

chrisbenincasa commented 4 years ago

Depends on #530

Problem

inject-ports is not cross-built for Scala 2.13.

Solution

Update inject-ports module to cross-build for Scala 2.13 using new SBT settings.

Result

inject-ports is cross-built for Scala 2.13.

codecov[bot] commented 4 years ago

Codecov Report

Merging #533 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #533   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files          267      267           
  Lines         4779     4779           
  Branches       288      297    +9     
========================================
  Hits          4337     4337           
  Misses         442      442

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94c43c5...908defe. Read the comment docs.

yufangong commented 4 years ago

Thanks! Merged at https://github.com/twitter/finatra/commit/a418dd26026da5da21d9f2156b0db7619c3002a8.