chrisbenincasa commented 4 years ago

Depends on #533 - last 2 commits only.

Problem

inject-app and inject-server are not cross-built for Scala 2.13.

Solution

Update inject-app and inject-server modules to cross-build for Scala 2.13 using new SBT settings.

Result

inject-app and inject-server are cross-built for Scala 2.13

codecov[bot] commented 4 years ago

Codecov Report

Merging #534 into develop will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #534   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files          267      267           
  Lines         4779     4779           
  Branches       288      288           
========================================
  Hits          4337     4337           
  Misses         442      442

Impacted Files	Coverage Δ
...pp/src/main/scala/com/twitter/inject/app/App.scala	`97.01% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a3be37...a442245. Read the comment docs.

yufangong commented 4 years ago

Merged at https://github.com/twitter/finatra/commit/03bb4f79563afd06834201045c72c276e3e4db83, thanks!

twitter / finatra

inject-app/inject-server: Cross-build for Scala 2.13 #534

Codecov Report