search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 406 forks source link

utils/validation: Cross-build for Scala 2.13 #535

Closed chrisbenincasa closed 3 years ago

chrisbenincasa commented 4 years ago

Depends on #534 - last commit only.

Problem

utils is not cross-built for Scala 2.13.

Solution

Update utils module to cross-build for Scala 2.13 using new SBT settings.

Result

utils is cross-built for Scala 2.13.

codecov[bot] commented 4 years ago

Codecov Report

Merging #535 into develop will increase coverage by 0.17%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #535      +/-   ##
===========================================
+ Coverage    90.75%   90.92%   +0.17%     
===========================================
  Files          267      269       +2     
  Lines         4779     4872      +93     
  Branches       288      307      +19     
===========================================
+ Hits          4337     4430      +93     
  Misses         442      442
Impacted Files Coverage Δ
...ala/com/twitter/finatra/validation/Validator.scala 94.11% <ø> (+0.36%) :arrow_up:
.../main/scala/com/twitter/inject/TwitterModule.scala 71.42% <0.00%> (-7.15%) :arrow_down:
.../com/twitter/inject/app/internal/FlagsModule.scala 98.00% <0.00%> (-2.00%) :arrow_down:
...e/src/main/scala/com/twitter/inject/Injector.scala 100.00% <0.00%> (ø)
...ala/com/twitter/inject/utils/AnnotationUtils.scala 100.00% <0.00%> (ø)
...tter/inject/thrift/filters/DarkTrafficFilter.scala 55.55% <0.00%> (ø)
...cala/com/twitter/finatra/example/QueueModule.scala 100.00% <0.00%> (ø)
...twitter/finatra/example/ExampleTwitterServer.scala 100.00% <0.00%> (ø)
...ain/scala/com/twitter/inject/TwitterInjector.scala 100.00% <0.00%> (ø)
...om/twitter/inject/app/internal/PrimitiveType.scala 71.42% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 03bb4f7...65a2fe4. Read the comment docs.

yufangong commented 3 years ago

Thank you for your patience, this is merged at https://github.com/twitter/finatra/commit/074cbaa2a616813a04cd8732072a7c343bcc6d67