twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 405 forks source link

finatra-kafka: Expose delivery timeout duration in KafkaProducerConfig #545

Closed HerveRiviere closed 4 years ago

HerveRiviere commented 4 years ago

Problem

Kafka producer configuration delivery.timeout.ms is not exposed in KafkaProducerConfig. It's a useful config to set an upper bound on the time to report success or failure after a call to producer.send() returns (kafka default : MAX_INT)

Solution

Expose delivery timeout duration in KafkaProducerConfig object. No associated flag in kafka-stream module as it doesn't really make sense to change it default value for a stream application

Describe the modifications you've done.

Addd of deliveryTimeout(duration: Duration) in ProducerConfig object.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #545 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #545   +/-   ##
========================================
  Coverage    90.68%   90.68%           
========================================
  Files          267      267           
  Lines         4779     4779           
  Branches       299      299           
========================================
  Hits          4334     4334           
  Misses         445      445           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2408860...a2ebbca. Read the comment docs.

bryce-anderson commented 4 years ago

Merged as cc02343057284fb3d0924b09909f2c28666b01e5. Thanks!