Closed yufangong closed 3 years ago
@yufangong we're likely going to need to put 2.13 into a matrix that doesn't fail the build, akin to the netty snapshot stuff. We may actually still have Scrooge or TwitterServer set up this way as well.
See: https://github.com/twitter/twitter-server/blob/develop/.travis.yml#L39
Merging #549 into develop will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #549 +/- ##
========================================
Coverage 90.75% 90.75%
========================================
Files 267 267
Lines 4779 4779
Branches 301 301
========================================
Hits 4337 4337
Misses 442 442
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update abb72f4...5daa0a1. Read the comment docs.
Problem
Explain the context and why you're making that change. What is the problem you're trying to solve? In some cases there is not a problem and this can be thought of being the motivation for your change.
Solution
Describe the modifications you've done.
Result
What will change as a result of your pull request? Note that sometimes this section is unnecessary because it is self-explanatory based on the solution.