search

twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 405 forks source link

inject-thrift: Cross-build for Scala 2.13 #551

Closed chrisbenincasa closed 3 years ago

chrisbenincasa commented 3 years ago

Problem

inject-thrift is not cross-built for Scala 2.13.

Solution

Update inject-thrift module to cross-build for Scala 2.13 using new SBT settings.

Result

inject-thrift is cross-built for Scala 2.13.

codecov[bot] commented 3 years ago

Codecov Report

Merging #551 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #551   +/-   ##
========================================
  Coverage    90.75%   90.75%           
========================================
  Files          267      267           
  Lines         4779     4779           
  Branches       288      297    +9     
========================================
  Hits          4337     4337           
  Misses         442      442

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94c43c5...10b536c. Read the comment docs.

yufangong commented 3 years ago

This is merged at https://github.com/twitter/finatra/commit/4c1ba45b7095ad463c6481bdb641421669a00b6f, thanks!!!