twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 405 forks source link

inject-mdc/thrift: Cross-build for Scala 2.13 #552

Closed chrisbenincasa closed 3 years ago

chrisbenincasa commented 3 years ago

Problem

inject-mdc and thrift modules are not cross-built for Scala 2.13.

Solution

Update modules to cross-build for Scala 2.13 using new SBT settings.

Result

inject-mdc/thrift modules are cross-built for Scala 2.13.

codecov[bot] commented 3 years ago

Codecov Report

Merging #552 into develop will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #552   +/-   ##
========================================
  Coverage    90.92%   90.92%           
========================================
  Files          269      269           
  Lines         4872     4872           
  Branches       304      303    -1     
========================================
  Hits          4430     4430           
  Misses         442      442           
Impacted Files Coverage Δ
.../twitter/finatra/thrift/routing/ThriftWarmup.scala 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 074cbaa...473664e. Read the comment docs.

cacoco commented 3 years ago

Merged: 6fe7267ae852bc025d9c275ec0428730bcaa1d1c