Closed chrisbenincasa closed 3 years ago
Merging #553 into develop will increase coverage by
0.02%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## develop #553 +/- ##
===========================================
+ Coverage 90.92% 90.94% +0.02%
===========================================
Files 269 269
Lines 4872 4872
Branches 304 303 -1
===========================================
+ Hits 4430 4431 +1
+ Misses 442 441 -1
Impacted Files | Coverage Δ | |
---|---|---|
.../twitter/finatra/thrift/routing/ThriftWarmup.scala | 75.00% <0.00%> (ø) |
|
...pp/src/main/scala/com/twitter/inject/app/App.scala | 98.50% <0.00%> (+1.49%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 074cbaa...11009a7. Read the comment docs.
@chrisbenincasa I have to apologize, I lost attribution when merging this here: 1e8dbd134c7b1d5e5fe37966d51e2ce5b96266a4. Really sorry about that. Let me know if you would like me to attempt to fix this.
No worries!
On Fri, Oct 9, 2020 at 4:44 PM Christopher Coco notifications@github.com wrote:
@chrisbenincasa https://github.com/chrisbenincasa I have to apologize, I lost attribution when merging this here: 1e8dbd1 https://github.com/twitter/finatra/commit/1e8dbd134c7b1d5e5fe37966d51e2ce5b96266a4. Really sorry about that. Let me know if you would like me to attempt to fix this.
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/twitter/finatra/pull/553#issuecomment-706394113, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMQRX4TQRDLH76NHX5T4LTSJ5YZRANCNFSM4RFANQVQ .
No worries!
Thanks for the work here! Merged in 1e8dbd134c7b1d5e5fe37966d51e2ce5b96266a4.
Problem
inject-request-scope is not cross-built for Scala 2.13.
Solution
Update inject-request-scope module to cross-build for Scala 2.13 using new SBT settings.
Result
inject-request-scope is cross-built for Scala 2.13.