twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 405 forks source link

[Test] revert scalacheck version #563

Closed jyanJing closed 3 years ago

jyanJing commented 3 years ago

We have seen failures in scala test after upgraded the scala check version. I suspect the failures are related to the upgrade. Reverting it back to see if the failures will go away.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #563 (782ef04) into develop (7a35f94) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 782ef04 differs from pull request most recent head e52685a. Consider uploading reports for the commit e52685a to get more accurate results Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #563   +/-   ##
========================================
  Coverage    88.83%   88.83%           
========================================
  Files          227      227           
  Lines         3664     3664           
  Branches       214      214           
========================================
  Hits          3255     3255           
  Misses         409      409           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a35f94...e52685a. Read the comment docs.