twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 405 forks source link

Reader[Buf] support request.param #568

Closed thinkiny closed 3 years ago

thinkiny commented 3 years ago

Is your feature request related to a problem? Please describe. when i use Reader[Buf] in controller, i can't parse the param

Describe the solution you'd like StreamingRequest support bytes stream

Describe alternatives you've considered Add another class like StreamBufRequest

thinkiny commented 3 years ago

found another way

yufangong commented 3 years ago

@thinkiny Hi! I didn't fully understand the problem, curious about your use cases and solutions, can you elaborate more? thanks!

thinkiny commented 3 years ago

from streaming example, something like this:

post("/upload/:*") {  reader => Reader[Buf]
    // how to get param *
}