twitter / finatra

Fast, testable, Scala services built on TwitterServer and Finagle
https://twitter.github.io/finatra/
Apache License 2.0
2.27k stars 405 forks source link

DO NOT MERGE: Revert "finatra-kafka: Update FinagleKafkaProducerIntegrationTest int… #578

Closed bryce-anderson closed 2 years ago

bryce-anderson commented 2 years ago

…egration test with timeouts"

This reverts commit 49f136d3697ea72e759c1a95d6bef849b3d9678d.

This is to see if this is the commit that broke the GH actions build.

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 2 years ago

Codecov Report

Merging #578 (57679ea) into develop (084257a) will decrease coverage by 0.02%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #578      +/-   ##
===========================================
- Coverage    90.27%   90.24%   -0.03%     
===========================================
  Files          227      227              
  Lines         3691     3691              
  Branches       214      206       -8     
===========================================
- Hits          3332     3331       -1     
- Misses         359      360       +1     
Impacted Files Coverage Δ
...pp/src/main/scala/com/twitter/inject/app/App.scala 98.43% <ø> (ø)
...cala/com/twitter/inject/modules/LoggerModule.scala 0.00% <ø> (-100.00%) :arrow_down:
...tter/inject/thrift/filters/DarkTrafficFilter.scala 70.37% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8336074...57679ea. Read the comment docs.

bryce-anderson commented 2 years ago

Served it's purpose.