search

twitter / hadoop-lzo

Refactored version of code.google.com/hadoop-gpl-compression for hadoop 0.20
GNU General Public License v3.0
546 stars 329 forks source link

renaming build.properties file to more specific to hadoop-lzo-build.properties #124

Closed cevaris closed 7 years ago

cevaris commented 7 years ago

Fix for #123

Problem

/build.properties as resource file name is too general of a name leading itself to conflict with other jar files.

Solution

Changing the name of the properties file /build.properties -> /hadoop-lzo-build.properties

Expected Result

Test should pass after maven recompilation; which should rebuild the build-info-* target.

sjlee commented 7 years ago

The change LGTM. I can't think of a case where changing this file name would cause a problem, even if somehow the old version and the new version of hadoop-lzo.jar get onto the same classpath.

sjlee commented 7 years ago

Thanks @cevaris for reporting the issue and providing the PR!