search

twitter / hadoop-lzo

Refactored version of code.google.com/hadoop-gpl-compression for hadoop 0.20
GNU General Public License v3.0
545 stars 328 forks source link

convert the build from ant/ivy to maven #70

Closed sjlee closed 11 years ago

sjlee commented 11 years ago

This changes the build from ant/ivy to maven. I believe it replicates most (if not all) of the build functionalities in maven. It should not result in a materially different build result.

sjlee commented 11 years ago

I'd love to get your feedback or review on this. Thanks!

sjlee commented 11 years ago

Feedback on this? How about the group id? Shall we use a different group id than the current one? Changing the group id is fine, but the implication is we may have class collisions if an upstream project includes both this and the old hadoop-lzo (transitively).

sjlee commented 11 years ago

Ping?

caniszczyk commented 11 years ago

Sorry, can you rebase the changes so the pull request can be merged?

If we don't use the 'com.twitter' groupId then we can't sync to central. I think it makes sense for us to use the com.twitter groupId because a) we kind of own this project b) we want to sync this to central

sjlee commented 11 years ago

Thanks Chris. The reason it cannot be merged automatically is not because it's not rebased properly but because a lot of files have been moved around (to conform to the standard maven directory layout). Once we resolve the group id discussion, I'd be happy to merge it myself.

rangadi commented 11 years ago

I am not really sure if it is acceptable to change the group id to com.twitter. How about we continue to publish to mvn.twitter.com for now as we have been doing as we look into it?

sjlee commented 11 years ago

+1. I would vote for merging it as is, and open a new issue for considering the group id change and continue the discussion. Thoughts?

caniszczyk commented 11 years ago

+1 for the new issue

On Jun 20, 2013, at 5:58 PM, Sangjin Lee notifications@github.com wrote:

+1. I would vote for merging it as is, and open a new issue for considering the group id change and continue the discussion. Thoughts?

— Reply to this email directly or view it on GitHubhttps://github.com/twitter/hadoop-lzo/pull/70#issuecomment-19789042 .

sjlee commented 11 years ago

I opened a new issue to discuss the group id issue. If you guys are OK with the changes, I'll merge this pull request. Let me know.

caniszczyk commented 11 years ago

+1 form me

sjlee commented 11 years ago

Cool, thanks. I'll go ahead and merge it today.