search

twitter / hogan.js

A compiler for the Mustache templating language
http://twitter.github.io/hogan.js
Apache License 2.0
5.14k stars 431 forks source link

Lambdas in multi level inheritance #166

Closed scanham closed 10 years ago

scanham commented 10 years ago

Lambdas in multi-level inheritance situations are currently being substituted incorrectly. This PR should fix that. The problem is that the test to see if activeSub undefined was always returning true for this situation and the text at the highest level was always being used.

scanham commented 10 years ago

This is the issue @nemtsov was referring to in his note in https://github.com/twitter/hogan.js/pull/149 and I hope it might be what @sayrer is referring to in his last comment on https://github.com/twitter/hogan.js/issues/111.

scanham commented 10 years ago

Oops - test is failing and I didn't see it. Will resubmit once fixed.

nemtsov commented 10 years ago

@sayrer I can confirm that this fixes the lambda issue I was referring to in #149.