search

twitter / hogan.js

A compiler for the Mustache templating language
http://twitter.github.io/hogan.js
Apache License 2.0
5.14k stars 431 forks source link

Standardize versioning and tags for Bower consumption #167

Closed jjt closed 3 years ago

jjt commented 10 years ago

It seems weird to $ bower install hogan#x.x.x and then reference bower_components/hogan/web/builds/x.x.x/hogan-x.x.x.js in my markup. Most other Bower components are built so that the component version matches the tag. Not many have the versioning information in the path either, nor do they have old built versions included.

Let's say I wanted to install Hogan v3.0.0 (once #164 is merged). I'd expect to $ bower install hogan#3.0.0 and reference bower_components/hogan/dist/hogan.js in my markup.

Also related, /lib/hogan.js states "This file is for use with Node.js. See dist/ for browser files".

nmstoker commented 10 years ago

Yes, the comment in /lib/hogan.js and the lack of /dist seemed odd to me too

sayrer commented 10 years ago

I'd take a patch to change this--I have no preference.

EdgarOrtegaRamirez commented 10 years ago

+1

dcharbonnier commented 10 years ago

+1 should be hogan.js and in the list of "scripts"

claar commented 9 years ago

+1 confused by this today.

sayrer commented 3 years ago

I'm going to close this, because I'm not sure anyone is still using Bower on new stuff. If I'm wrong, feel free to reopen or refile.